[REACT] When using a custom day filter, events on filtered out days are slightly visible

[kinetic]

Hi Bryntum Support,

We have found another slight difference after upgrading the calendar version - we use a custom filter on our toolbar for selecting days of the week, the selected days are stored in a variable which we use in the filterBy function:

calendarRef.current.instance.activeView.timeAxis.filterBy((tick) =>
          visibleDays.includes(tick.startDate.getDay())
        );

Prior to upgrading (from version 4.2.5), a very small part of the card is visible (on inspection the height is set to 0px) - if you hover close enough you could click on it and load some details but it's not a big problem.

Visible event cards before.png (181.38 KiB) Viewed 242 times

After upgrading you can see the filtered out cards are more visible. Nothing has changed in the code and on inspection the element height is still 0px. Could it be something has changed in the theme across the versions? Maybe we can apply some fix to the css?:

Visible event cards after.png (203.67 KiB) Viewed 242 times

Please let us know if you require any additional details on the code etc.

Thanks

[ghulam.ghous]

Hi Kinetic,

They shouldn't be visible. Need a test case here so we can reproduce this issue and if they are visible it is probably a bug. Please share a runnable project with minimum code to repro this issue. You can use our online examples as a standard and add your code into them.

Regards,
Ghous

[Animal]

The Scheduler package (That is a Scheduler in vertical mode that you appear to be using as a custom mode there) does not simply hide sub elements using CSS.

Go to https://bryntum.com/products/scheduler/examples/bigdataset-vertical/

Then type the following into the debugger:

scheduler.timeAxis.filterBy((tick) =>
    tick.startDate.getDay() !== 6 && tick.startDate.getDay() !== 0
);

You should see the two weekend days disappear. It refreshes the DOM without the filtered out ticks.

I suspect React.

[kinetic]

Hello,

Thank you both for your quick replies - we tried a few more things and after some large amount of console logging realised the events weren't actually being filtered out, only the days.

We replicated the filterBy function (which we were already using on the timeAxis) on the eventStore and now everything is working properly.....happy to report you don't have a bug

Thanks again for the assistance.

[ghulam.ghous]

Hi Kinetic,

We are glad to hear to that you have solved the issue and sigh of relief that it is not a bug on our side Please don't hesitate to reach out to us if you have any further queries.

Regards,
Ghous