Our state of the art Gantt chart


Post by akuang »

Hi,

I've been working on integrating the Gantt with an existing codebase that is primarily in Typescript and have found some bugs in the typings that are shipped with the artifact:

  • BryntumWidgetAdapterRegister is missing a declaration

  • BryntumWidgetAdapter's declaration is blank

  • TaskModelConfig only has one field, listeners

  • This may not be a bug, but it would still be convenient to export the Config types, e.g. TaskModelConfig + ProjectModelConfig

  • MessageDialog.confirm says it is returning void, though it should return a Promise based on its implementation. Type def:

export class MessageDialog extends Popup {
    constructor(config?: Partial<MessageDialogConfig>);
    static confirm(options: object): void;
} 

Implementation returns:

return me.promise = new Promise(resolve => {
  me.resolve = resolve;
});
  • yesButton, noButton, and cancelButton should also probably be added to the MessageDialog type.

Thanks,
Alex


Post by mats »

Thanks for the report, ticket opened: https://github.com/bryntum/support/issues/1098


Post Reply